feat(navigation): restore address book navigation in sidebar#5421
feat(navigation): restore address book navigation in sidebar#5421pagaille wants to merge 1 commit into
Conversation
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
hamza221
added
enhancement
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
|
Thank you for the PR LGTM, |
hamza221
left a comment
hamza221
left a comment
There was a problem hiding this comment.
Please rebase and run npm run lint:fix
Address books used to be listed in the left sidebar (via the now-deleted SettingsSection.vue), allowing users to click on a book to filter their contacts. This was removed in bd536c0 when settings were migrated to a modal dialog, without any navigation replacement — making the "New address book" feature essentially invisible and unusable. Changes: - Add "Address books" section in RootNavigation with one item per enabled address book and a contact counter - Add ROUTE_ADDRESSBOOK constant and addressbook/:selectedAddressbook and addressbook/:selectedAddressbook/:selectedContact routes - Add selectedAddressbook to RouterMixin - Filter contactsList by selected address book when on the addressbook route - New contacts created while an address book is selected are saved into that address book instead of the default one - Fix "Missing required param selectedGroup" errors in selectFirstContactIfNone(), ContactsListItem, and ContactDetails (moveContactToAddressbook / copyContactToAddressbook) when navigating without a selectedGroup param Fixes nextcloud#3647 Assisted-by: Claude:claude-sonnet-4-6 Signed-off-by: Matthieu <webmail@gaillet.be>
3044517 to
49132fd
Compare
2 participants
Fixes #3647
Summary
Address books used to be listed in the left sidebar (via the now-deleted
SettingsSection.vue), allowing users to click on a book to filter their contacts. This was removed in bd536c0 when settings were migrated to a modal dialog, without any navigation replacement — making the "New address book" feature essentially invisible and unusable.Changes:
ROUTE_ADDRESSBOOKconstant andaddressbook/:selectedAddressbook+addressbook/:selectedAddressbook/:selectedContactroutesselectedAddressbooktoRouterMixincontactsListby the selected address book when on the addressbook routeMissing required param "selectedGroup"errors inselectFirstContactIfNone(),ContactsListItem, andContactDetails(moveContactToAddressbook/copyContactToAddressbook) when navigating without aselectedGroupparamTest plan
🤖 Generated with Claude Code